Uploaded image for project: 'XenServer Org'
  1. XenServer Org
  2. XSO-882

unused source file in vhd-tool's source RPM

    Details

    • Type: Bug
    • Status: Done (View Workflow)
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 7.5
    • Fix Version/s: 8.0
    • Component/s: other
    • Labels:
      None
    • Internal JIRA Reference:
      XSI-68

      Description

      The vhd-tool source RPM contains a source file named vhd-tool-sparse_dd-conf, outside of the vhd-tool-0.20.0.tar.gz source tarball.

       

      It appears that the vhd-tool-sparse_dd-conf file is not used during the build (it's copied in the %prep section but then it's ignored in %build and %install).

       

      I suggest you remove the file and patch the spec file this way:

      Index: vhd-tool.spec
      ===================================================================
      --- vhd-tool.spec
      +++ vhd-tool.spec       2018-08-06 17:36:05.285884474 +0200
      @@ -7,7 +7,6 @@
       URL:  https://github.com/xapi-project/vhd-tool
       Source0: https://code.citrite.net/rest/archive/latest/projects/XSU/repos/%{name}/archive?at=v%{version}&format=tar.gz&prefix=%{name}-%{version}#/%{name}-%{version}.tar.gz
       Provides: gitsha(https://code.citrite.net/rest/archive/latest/projects/XSU/repos/vhd-tool/archive?at=v0.20.0&format=tar.gz&prefix=vhd-tool-0.20.0#/vhd-tool-0.20.0.tar.gz) = 76a543f11ea62aa2e56c4ba55c2bb898f121d2b2
      -Source1: vhd-tool-sparse_dd-conf
       BuildRequires: ocaml-camlp4-devel
       BuildRequires: xs-opam-repo
       BuildRequires: ocaml-xcp-idl-devel
      @@ -19,7 +18,6 @@
       
       %prep
       %autosetup -p1
      -cp %{SOURCE1} vhd-tool-sparse_dd-conf
       
       
       %build

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              stormi Samuel Verschelde
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: