Description
This is a regression in CH 8.1.
On UEFI hosts, using the installer to restore from the backup partition fails at the bootloader setup stage, with error "setEfiBootEntry() takes exactly 5 arguments (4 given)".
This leaves the host in an unbootable state.
The error comes from this line: https://github.com/xcp-ng/host-installer/blob/XS-8.1.0/restore.py#L137
In 8.1, the setEfiBootEntry method signature has been changed to add a 'install_type' parameter, but only one of the two calls to this function was updated.
Exact steps to reproduce:
- Install CH 8.0 on an UEFI host.
- Upgrade to CH 8.1
- Use the CH 8.1 installer to revert to 8.0
Note : has been reproduced by several users on XCP-ng 8.1, in addition to my test on CH 8.1 (see attached screenshot)